Fix missing symbols for singlefilehost - #73269
Merged
Merged
Conversation
|
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov Issue DetailsThe symbol packages were missing symbols for Fixes #71735
|
ghost
assigned
am11
reviewed
Aug 2, 2022
jkoritzinsky
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol packages were missing symbols for
singlefilehostbecause they weren't being copied to the expected location, resulting insinglefilehost.dbg/pdbnot being published. This updates thePrepareSingleFileHostWithEmbeddedDacCoretarget to copy the symbol file from and to the expected locations (PDB sudbirectory for Windows, next to the binary for non-Windows).Fixes #71735